Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cycles : Remove dupli_generated and dupli_uv attributes #5719

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

johnhaddon
Copy link
Member

Now we have proper support for arbitrary user: attributes, these are strange outliers. I don't think they really make sense in a non-Blender context. If anyone is using them, or otherwise feels they deserve to stay, speak now!

@johnhaddon johnhaddon self-assigned this Mar 7, 2024
@boberfly
Copy link
Collaborator

boberfly commented Mar 8, 2024

Just to jot down what I had in the Discord:

There are some shaders that would use these:
https://github.com/blender/cycles/blob/main/src/scene/shader_nodes.h#L912

https://github.com/blender/cycles/blob/main/src/kernel/svm/tex_coord.h#L73
https://github.com/blender/cycles/blob/main/src/kernel/osl/shaders/node_texture_coordinate.osl#L35

So I am not too sure on this one, I don't personally use them and would just use a constant user attribute probably, like you mentioned.

Edit: I was going to suggest the CyclesAttributesUI be removed but any USD caches that come in could use them in the backend if detected, but I don't see their exporter nor the Hydra delegate use them anyways.

@johnhaddon
Copy link
Member Author

Thanks for your thoughts @boberfly. I'm going to take an executive decision on this for now and merge. It won't be hard to bring back (with or without the UI) if it turns out I was wrong.

Now we have proper support for arbitrary `user:` attributes, these are strange outliers. I don't think they really make sense in a non-Blender context.
@johnhaddon johnhaddon merged commit d58d50b into GafferHQ:main Mar 15, 2024
5 checks passed
@johnhaddon johnhaddon deleted the removeDupli branch March 15, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants